2D Toolkit Forum

2D Toolkit => Releases => Topic started by: unikronsoftware on August 01, 2017, 08:00:34 pm

Title: 2D Toolkit 2.5.8.3
Post by: unikronsoftware on August 01, 2017, 08:00:34 pm
Please read the migration guide before updating. 2D Toolkit 2.x is not API compatible with 1.x.
http://2dtoolkit.com/docs/2.4/migration_guide.html

Documentation available at:
http://2dtoolkit.com/docs/2.5


Be sure to run "Setup for JavaScript" after importing if you're using JavaScript/UnityScript or Boo.

What's new

Bug fixes and improvements
Title: Re: 2D Toolkit 2.5.8.3
Post by: playspace on August 03, 2017, 12:10:34 pm
Hi there, I just saw that you added #if UNITY_VERSION > 550 into the shader code to handle the mul(UNITY_MATRIX_MVP,*) to UnityObjectToClipPos(*) case.

While this is correct I think you are missing the // UNITY_SHADER_NO_UPGRADE flag if not Unity will just upgrade both parts of the conditional code.
Title: Re: 2D Toolkit 2.5.8.3
Post by: unikronsoftware on August 03, 2017, 01:55:53 pm
Hi, Thanks for that!

I am slightly worried to add that in case a future unity update breaks something in the shader that is fixed by the auto-updating thing, but since that is turned off, it just ends up breaking catastrophically... Any thoughts?
Title: Re: 2D Toolkit 2.5.8.3
Post by: playspace on August 03, 2017, 03:33:57 pm
I think it's just something we have to maintain by hand. Unity should not upgrade those parts if thei are enclosed in the right defines, so using those defines without the flag is completely useless (rendering the version defines itself usless xD). So I guess it's just reading release notes and checking nothing breaks, a good think is that it will break at shader compile time so it should be easy to spot.

Cheers,
Moss